jerem/node-notifier
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

refactor: move services into services directory

Browse Source
This commit is contained in:
JeremyLARDENOIS
2025-08-10 17:58:51 +02:00
parent 8a0c71c494
commit c1177c5ea5
7 changed files with 13 additions and 148 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/adapters/driving/for_monitoring_alerts.rs
View File

@@ -2,11 +2,11 @@ use crate::app::ports::driving::ForMonitoringAlerts;
pub struct ForMonitoringAlertsAdapter
{
app : crate::app::alert_service::AlertService
app : crate::app::services::alert_service::AlertService
}
impl ForMonitoringAlertsAdapter {
pub fn new(app: crate::app::alert_service::AlertService) -> Self {
pub fn new(app: crate::app::services::alert_service::AlertService) -> Self {
ForMonitoringAlertsAdapter { app }
}
}

2
src/app/ports.rs
View File

@@ -1,2 +0,0 @@
pub mod driven;
pub mod driving;

138
src/app/service.rs
View File

@@ -1,138 +0,0 @@
use crate::app::ports::driven::{
ForFormattingMessage, ForMonitoringSystem, ForSendingNotification,
};
pub struct Service {
notifier: Box<dyn ForSendingNotification>,
monitor: Box<dyn ForMonitoringSystem>,
formatter: Box<dyn ForFormattingMessage>,
}
pub fn new(
notifier: Box<dyn ForSendingNotification>,
monitor: Box<dyn ForMonitoringSystem>,
formatter: Box<dyn ForFormattingMessage>,
) -> Service {
Service {
notifier,
monitor,
formatter,
}
}
impl Service {
/// Check for threshold violations and send alerts
pub fn alert_on_threshold_violation(&self) -> Result<(), Box<dyn std::error::Error>> {
let violations = self.monitor.check_thresholds();
for violation in violations {
let message = self.formatter.format_violation(violation);
self.notifier.send_notification(&message)?;
}
Ok(())
}
/// Send a final notification with all system information
pub fn send_all_metrics_notification(&self) -> Result<(), Box<dyn std::error::Error>> {
let summary = self.formatter.format_summary(&self.monitor.get_metrics());
self.notifier.send_notification(&summary)?;
Ok(())
}
}
#[cfg(test)]
mod tests {
use std::collections::HashMap;
use crate::app::ports::driven::{MockForFormattingMessage, MockForMonitoringSystem, MockForSendingNotification};
use super::*;
#[test]
fn test_alert_on_threshold_violation() {
let mut notifier = MockForSendingNotification::new();
let mut monitor = MockForMonitoringSystem::new();
let mut formatter = MockForFormattingMessage::new();
notifier.expect_send_notification().returning(|_| Ok(()));
monitor.expect_check_thresholds().returning(|| vec![]);
monitor.expect_get_metrics().returning(|| HashMap::new());
formatter.expect_format_violation().returning(|_| "".to_string());
formatter.expect_format_summary().returning(|_| "".to_string());
let service = new(
Box::new(notifier),
Box::new(monitor),
Box::new(formatter),
);
assert!(service.alert_on_threshold_violation().is_ok());
}
#[test]
fn test_send_all_metrics_notification() {
let mut notifier = MockForSendingNotification::new();
let mut monitor = MockForMonitoringSystem::new();
let mut formatter = MockForFormattingMessage::new();
notifier.expect_send_notification().returning(|_| Ok(()));
monitor.expect_check_thresholds().returning(|| vec![]);
monitor.expect_get_metrics().returning(|| HashMap::new());
formatter.expect_format_violation().returning(|_| "".to_string());
formatter.expect_format_summary().returning(|_| "".to_string());
let service = new(
Box::new(notifier),
Box::new(monitor),
Box::new(formatter),
);
assert!(service.send_all_metrics_notification().is_ok());
}
#[test]
fn test_alert_on_threshold_violation_handles_send_error() {
let mut notifier = MockForSendingNotification::new();
let mut monitor = MockForMonitoringSystem::new();
let mut formatter = MockForFormattingMessage::new();
monitor.expect_check_thresholds().returning(|| {
vec![Box::new(crate::app::ports::driven::MockForGettingViolationData::new())]
});
formatter.expect_format_violation().returning(|_| "Test violation".to_string());
notifier.expect_send_notification()
.returning(|_| Err("Network error".into()));
let service = new(
Box::new(notifier),
Box::new(monitor),
Box::new(formatter),
);
assert!(service.alert_on_threshold_violation().is_err());
}
#[test]
fn test_send_all_metrics_notification_handles_send_error() {
let mut notifier = MockForSendingNotification::new();
let mut monitor = MockForMonitoringSystem::new();
let mut formatter = MockForFormattingMessage::new();
monitor.expect_get_metrics().returning(|| HashMap::new());
formatter.expect_format_summary().returning(|_| "Test summary".to_string());
notifier.expect_send_notification()
.returning(|_| Err("Network error".into()));
let service = new(
Box::new(notifier),
Box::new(monitor),
Box::new(formatter),
);
assert!(service.send_all_metrics_notification().is_err());
}
}

0
src/app/alert_service.rs → src/app/services/alert_service.rs
View File

0
src/app/metric_service.rs → src/app/services/metric_service.rs
View File

6
src/configurator.rs
View File

@@ -23,7 +23,7 @@ pub fn get_cron_actor(
let formatter = actors::driven::for_formatting_message::alert_formatter::AlertFormatter;
let service = app::alert_service::new(
let service = app::services::alert_service::new(
Box::new(discord_adapter),
Box::new(system_monitor_adapter),
Box::new(formatter),
@@ -34,7 +34,7 @@ pub fn get_cron_actor(
actors::driving::cron_alerts::CronAlertsActor::new(Box::new(service_adapter), duration)
}
pub fn get_get_service() -> app::metric_service::MetricService {
pub fn get_get_service() -> app::services::metric_service::MetricService {
let notifier = actors::driven::for_sending_notification::print::StdoutNotificationActor::new();
let monitor =
@@ -44,7 +44,7 @@ pub fn get_get_service() -> app::metric_service::MetricService {
let formatter = actors::driven::for_formatting_message::alert_formatter::AlertFormatter;
app::metric_service::new(
app::services::metric_service::new(
Box::new(notifier),
Box::new(system_monitor_adapter),
Box::new(formatter),

11
src/main.rs
View File

@@ -1,9 +1,14 @@
use clap::{Parser, Subcommand};
mod app {
pub mod alert_service;
pub mod metric_service;
pub mod ports;
pub mod services {
pub mod alert_service;
pub mod metric_service;
}
pub mod ports {
pub mod driven;
pub mod driving;
}
}
mod adapters {